1use crate::ClippyConfiguration;
2use crate::types::{
3 DisallowedPath, DisallowedPathWithoutReplacement, MacroMatcher, MatchLintBehaviour, PubUnderscoreFieldsBehaviour,
4 Rename, SourceItemOrdering, SourceItemOrderingCategory, SourceItemOrderingModuleItemGroupings,
5 SourceItemOrderingModuleItemKind, SourceItemOrderingTraitAssocItemKind, SourceItemOrderingTraitAssocItemKinds,
6 SourceItemOrderingWithinModuleItemGroupings,
7};
8use clippy_utils::msrvs::Msrv;
9use itertools::Itertools;
10use rustc_errors::Applicability;
11use rustc_session::Session;
12use rustc_span::edit_distance::edit_distance;
13use rustc_span::{BytePos, Pos, SourceFile, Span, SyntaxContext};
14use serde::de::{IgnoredAny, IntoDeserializer, MapAccess, Visitor};
15use serde::{Deserialize, Deserializer, Serialize};
16use std::collections::HashMap;
17use std::fmt::{Debug, Display, Formatter};
18use std::ops::Range;
19use std::path::PathBuf;
20use std::str::FromStr;
21use std::sync::OnceLock;
22use std::{cmp, env, fmt, fs, io};
23
24#[rustfmt::skip]
25const DEFAULT_DOC_VALID_IDENTS: &[&str] = &[
26 "KiB", "MiB", "GiB", "TiB", "PiB", "EiB",
27 "MHz", "GHz", "THz",
28 "AccessKit",
29 "CoAP", "CoreFoundation", "CoreGraphics", "CoreText",
30 "DevOps",
31 "Direct2D", "Direct3D", "DirectWrite", "DirectX",
32 "ECMAScript",
33 "GPLv2", "GPLv3",
34 "GitHub", "GitLab",
35 "IPv4", "IPv6",
36 "ClojureScript", "CoffeeScript", "JavaScript", "PostScript", "PureScript", "TypeScript",
37 "WebAssembly",
38 "NaN", "NaNs",
39 "OAuth", "GraphQL",
40 "OCaml",
41 "OpenAL", "OpenDNS", "OpenGL", "OpenMP", "OpenSSH", "OpenSSL", "OpenStreetMap", "OpenTelemetry",
42 "OpenType",
43 "WebGL", "WebGL2", "WebGPU", "WebRTC", "WebSocket", "WebTransport",
44 "WebP", "OpenExr", "YCbCr", "sRGB",
45 "TensorFlow",
46 "TrueType",
47 "iOS", "macOS", "FreeBSD", "NetBSD", "OpenBSD",
48 "TeX", "LaTeX", "BibTeX", "BibLaTeX",
49 "MinGW",
50 "CamelCase",
51];
52const DEFAULT_DISALLOWED_NAMES: &[&str] = &["foo", "baz", "quux"];
53const DEFAULT_ALLOWED_IDENTS_BELOW_MIN_CHARS: &[&str] = &["i", "j", "x", "y", "z", "w", "n"];
54const DEFAULT_ALLOWED_PREFIXES: &[&str] = &["to", "as", "into", "from", "try_into", "try_from"];
55const DEFAULT_ALLOWED_TRAITS_WITH_RENAMED_PARAMS: &[&str] =
56 &["core::convert::From", "core::convert::TryFrom", "core::str::FromStr"];
57const DEFAULT_MODULE_ITEM_ORDERING_GROUPS: &[(&str, &[SourceItemOrderingModuleItemKind])] = {
58 #[allow(clippy::enum_glob_use)] use SourceItemOrderingModuleItemKind::*;
60 &[
61 ("modules", &[ExternCrate, Mod, ForeignMod]),
62 ("use", &[Use]),
63 ("macros", &[Macro]),
64 ("global_asm", &[GlobalAsm]),
65 ("UPPER_SNAKE_CASE", &[Static, Const]),
66 ("PascalCase", &[TyAlias, Enum, Struct, Union, Trait, TraitAlias, Impl]),
67 ("lower_snake_case", &[Fn]),
68 ]
69};
70const DEFAULT_TRAIT_ASSOC_ITEM_KINDS_ORDER: &[SourceItemOrderingTraitAssocItemKind] = {
71 #[allow(clippy::enum_glob_use)] use SourceItemOrderingTraitAssocItemKind::*;
73 &[Const, Type, Fn]
74};
75const DEFAULT_SOURCE_ITEM_ORDERING: &[SourceItemOrderingCategory] = {
76 #[allow(clippy::enum_glob_use)] use SourceItemOrderingCategory::*;
78 &[Enum, Impl, Module, Struct, Trait]
79};
80
81#[derive(Default)]
83struct TryConf {
84 conf: Conf,
85 value_spans: HashMap<String, Range<usize>>,
86 errors: Vec<ConfError>,
87 warnings: Vec<ConfError>,
88}
89
90impl TryConf {
91 fn from_toml_error(file: &SourceFile, error: &toml::de::Error) -> Self {
92 Self {
93 conf: Conf::default(),
94 value_spans: HashMap::default(),
95 errors: vec![ConfError::from_toml(file, error)],
96 warnings: vec![],
97 }
98 }
99}
100
101#[derive(Debug)]
102struct ConfError {
103 message: String,
104 suggestion: Option<Suggestion>,
105 span: Span,
106}
107
108impl ConfError {
109 fn from_toml(file: &SourceFile, error: &toml::de::Error) -> Self {
110 let span = error.span().unwrap_or(0..file.source_len.0 as usize);
111 Self::spanned(file, error.message(), None, span)
112 }
113
114 fn spanned(
115 file: &SourceFile,
116 message: impl Into<String>,
117 suggestion: Option<Suggestion>,
118 span: Range<usize>,
119 ) -> Self {
120 Self {
121 message: message.into(),
122 suggestion,
123 span: span_from_toml_range(file, span),
124 }
125 }
126}
127
128pub fn sanitize_explanation(raw_docs: &str) -> String {
130 let mut explanation = String::with_capacity(128);
132 let mut in_code = false;
133 for line in raw_docs.lines() {
134 let line = line.strip_prefix(' ').unwrap_or(line);
135
136 if let Some(lang) = line.strip_prefix("```") {
137 let tag = lang.split_once(',').map_or(lang, |(left, _)| left);
138 if !in_code && matches!(tag, "" | "rust" | "ignore" | "should_panic" | "no_run" | "compile_fail") {
139 explanation += "```rust\n";
140 } else {
141 explanation += line;
142 explanation.push('\n');
143 }
144 in_code = !in_code;
145 } else if !(in_code && line.starts_with("# ")) {
146 explanation += line;
147 explanation.push('\n');
148 }
149 }
150
151 explanation
152}
153
154macro_rules! wrap_option {
155 () => {
156 None
157 };
158 ($x:literal) => {
159 Some($x)
160 };
161}
162
163macro_rules! default_text {
164 ($value:expr) => {{
165 let mut text = String::new();
166 $value.serialize(toml::ser::ValueSerializer::new(&mut text)).unwrap();
167 text
168 }};
169 ($value:expr, $override:expr) => {
170 $override.to_string()
171 };
172}
173
174macro_rules! deserialize {
175 ($map:expr, $ty:ty, $errors:expr, $file:expr) => {{
176 let raw_value = $map.next_value::<toml::Spanned<toml::Value>>()?;
177 let value_span = raw_value.span();
178 let value = match <$ty>::deserialize(raw_value.into_inner()) {
179 Err(e) => {
180 $errors.push(ConfError::spanned(
181 $file,
182 e.to_string().replace('\n', " ").trim(),
183 None,
184 value_span,
185 ));
186 continue;
187 },
188 Ok(value) => value,
189 };
190 (value, value_span)
191 }};
192
193 ($map:expr, $ty:ty, $errors:expr, $file:expr, $replacements_allowed:expr) => {{
194 let array = $map.next_value::<Vec<toml::Spanned<toml::Value>>>()?;
195 let mut disallowed_paths_span = Range {
196 start: usize::MAX,
197 end: usize::MIN,
198 };
199 let mut disallowed_paths = Vec::new();
200 for raw_value in array {
201 let value_span = raw_value.span();
202 let mut disallowed_path = match DisallowedPath::<$replacements_allowed>::deserialize(raw_value.into_inner())
203 {
204 Err(e) => {
205 $errors.push(ConfError::spanned(
206 $file,
207 e.to_string().replace('\n', " ").trim(),
208 None,
209 value_span,
210 ));
211 continue;
212 },
213 Ok(disallowed_path) => disallowed_path,
214 };
215 disallowed_paths_span = union(&disallowed_paths_span, &value_span);
216 disallowed_path.set_span(span_from_toml_range($file, value_span));
217 disallowed_paths.push(disallowed_path);
218 }
219 (disallowed_paths, disallowed_paths_span)
220 }};
221}
222
223macro_rules! define_Conf {
224 ($(
225 $(#[doc = $doc:literal])+
226 $(#[conf_deprecated($dep:literal, $new_conf:ident)])?
227 $(#[default_text = $default_text:expr])?
228 $(#[disallowed_paths_allow_replacements = $replacements_allowed:expr])?
229 $(#[lints($($for_lints:ident),* $(,)?)])?
230 $name:ident: $ty:ty = $default:expr,
231 )*) => {
232 pub struct Conf {
234 $($(#[cfg_attr(doc, doc = $doc)])+ pub $name: $ty,)*
235 }
236
237 mod defaults {
238 use super::*;
239 $(pub fn $name() -> $ty { $default })*
240 }
241
242 impl Default for Conf {
243 fn default() -> Self {
244 Self { $($name: defaults::$name(),)* }
245 }
246 }
247
248 #[derive(Deserialize)]
249 #[serde(field_identifier, rename_all = "kebab-case")]
250 #[allow(non_camel_case_types)]
251 enum Field { $($name,)* third_party, }
252
253 struct ConfVisitor<'a>(&'a SourceFile);
254
255 impl<'de> Visitor<'de> for ConfVisitor<'_> {
256 type Value = TryConf;
257
258 fn expecting(&self, formatter: &mut fmt::Formatter<'_>) -> fmt::Result {
259 formatter.write_str("Conf")
260 }
261
262 fn visit_map<V>(self, mut map: V) -> Result<Self::Value, V::Error> where V: MapAccess<'de> {
263 let mut value_spans = HashMap::new();
264 let mut errors = Vec::new();
265 let mut warnings = Vec::new();
266
267 $(let mut $name = None;)*
269
270 while let Some(name) = map.next_key::<toml::Spanned<String>>()? {
272 let field = match Field::deserialize(name.get_ref().as_str().into_deserializer()) {
273 Err(e) => {
274 let e: FieldError = e;
275 errors.push(ConfError::spanned(self.0, e.error, e.suggestion, name.span()));
276 continue;
277 }
278 Ok(field) => field
279 };
280
281 match field {
282 $(Field::$name => {
283 $(warnings.push(ConfError::spanned(self.0, format!("deprecated field `{}`. {}", name.get_ref(), $dep), None, name.span()));)?
285 let (value, value_span) =
286 deserialize!(map, $ty, errors, self.0 $(, $replacements_allowed)?);
287 if $name.is_some() {
289 errors.push(ConfError::spanned(self.0, format!("duplicate field `{}`", name.get_ref()), None, name.span()));
290 continue;
291 }
292 $name = Some(value);
293 value_spans.insert(name.get_ref().as_str().to_string(), value_span);
294 $(match $new_conf {
297 Some(_) => errors.push(ConfError::spanned(self.0, concat!(
298 "duplicate field `", stringify!($new_conf),
299 "` (provided as `", stringify!($name), "`)"
300 ), None, name.span())),
301 None => $new_conf = $name.clone(),
302 })?
303 })*
304 Field::third_party => drop(map.next_value::<IgnoredAny>())
306 }
307 }
308 let conf = Conf { $($name: $name.unwrap_or_else(defaults::$name),)* };
309 Ok(TryConf { conf, value_spans, errors, warnings })
310 }
311 }
312
313 pub fn get_configuration_metadata() -> Vec<ClippyConfiguration> {
314 vec![$(
315 ClippyConfiguration {
316 name: stringify!($name).replace('_', "-"),
317 default: default_text!(defaults::$name() $(, $default_text)?),
318 lints: &[$($(stringify!($for_lints)),*)?],
319 doc: concat!($($doc, '\n',)*),
320 deprecation_reason: wrap_option!($($dep)?)
321 },
322 )*]
323 }
324 };
325}
326
327fn union(x: &Range<usize>, y: &Range<usize>) -> Range<usize> {
328 Range {
329 start: cmp::min(x.start, y.start),
330 end: cmp::max(x.end, y.end),
331 }
332}
333
334fn span_from_toml_range(file: &SourceFile, span: Range<usize>) -> Span {
335 Span::new(
336 file.start_pos + BytePos::from_usize(span.start),
337 file.start_pos + BytePos::from_usize(span.end),
338 SyntaxContext::root(),
339 None,
340 )
341}
342
343define_Conf! {
344 #[lints(absolute_paths)]
346 absolute_paths_allowed_crates: Vec<String> = Vec::new(),
347 #[lints(absolute_paths)]
350 absolute_paths_max_segments: u64 = 2,
351 #[lints(undocumented_unsafe_blocks)]
353 accept_comment_above_attributes: bool = true,
354 #[lints(undocumented_unsafe_blocks)]
356 accept_comment_above_statement: bool = true,
357 #[lints(modulo_arithmetic)]
359 allow_comparison_to_zero: bool = true,
360 #[lints(dbg_macro)]
362 allow_dbg_in_tests: bool = false,
363 #[lints(expect_used)]
365 allow_expect_in_consts: bool = true,
366 #[lints(expect_used)]
368 allow_expect_in_tests: bool = false,
369 #[lints(indexing_slicing)]
371 allow_indexing_slicing_in_tests: bool = false,
372 #[lints(uninlined_format_args)]
374 allow_mixed_uninlined_format_args: bool = true,
375 #[lints(needless_raw_string_hashes)]
377 allow_one_hash_in_raw_strings: bool = false,
378 #[lints(panic)]
380 allow_panic_in_tests: bool = false,
381 #[lints(print_stderr, print_stdout)]
383 allow_print_in_tests: bool = false,
384 #[lints(module_inception)]
386 allow_private_module_inception: bool = false,
387 #[lints(renamed_function_params)]
401 allow_renamed_params_for: Vec<String> =
402 DEFAULT_ALLOWED_TRAITS_WITH_RENAMED_PARAMS.iter().map(ToString::to_string).collect(),
403 #[lints(unwrap_used)]
405 allow_unwrap_in_consts: bool = true,
406 #[lints(unwrap_used)]
408 allow_unwrap_in_tests: bool = false,
409 #[lints(useless_vec)]
411 allow_useless_vec_in_tests: bool = false,
412 #[lints(path_ends_with_ext)]
414 allowed_dotfiles: Vec<String> = Vec::default(),
415 #[lints(multiple_crate_versions)]
417 allowed_duplicate_crates: Vec<String> = Vec::new(),
418 #[lints(min_ident_chars)]
422 allowed_idents_below_min_chars: Vec<String> =
423 DEFAULT_ALLOWED_IDENTS_BELOW_MIN_CHARS.iter().map(ToString::to_string).collect(),
424 #[lints(module_name_repetitions)]
442 allowed_prefixes: Vec<String> = DEFAULT_ALLOWED_PREFIXES.iter().map(ToString::to_string).collect(),
443 #[lints(disallowed_script_idents)]
445 allowed_scripts: Vec<String> = vec!["Latin".to_string()],
446 #[lints(wildcard_imports)]
460 allowed_wildcard_imports: Vec<String> = Vec::new(),
461 #[lints(arithmetic_side_effects)]
476 arithmetic_side_effects_allowed: Vec<String> = <_>::default(),
477 #[lints(arithmetic_side_effects)]
492 arithmetic_side_effects_allowed_binary: Vec<(String, String)> = <_>::default(),
493 #[lints(arithmetic_side_effects)]
501 arithmetic_side_effects_allowed_unary: Vec<String> = <_>::default(),
502 #[lints(large_const_arrays, large_stack_arrays)]
504 array_size_threshold: u64 = 16 * 1024,
505 #[lints(
507 box_collection,
508 enum_variant_names,
509 large_types_passed_by_value,
510 linkedlist,
511 needless_pass_by_ref_mut,
512 option_option,
513 owned_cow,
514 rc_buffer,
515 rc_mutex,
516 redundant_allocation,
517 ref_option,
518 single_call_fn,
519 trivially_copy_pass_by_ref,
520 unnecessary_box_returns,
521 unnecessary_wraps,
522 unused_self,
523 upper_case_acronyms,
524 vec_box,
525 wrong_self_convention,
526 )]
527 avoid_breaking_exported_api: bool = true,
528 #[disallowed_paths_allow_replacements = false]
530 #[lints(await_holding_invalid_type)]
531 await_holding_invalid_types: Vec<DisallowedPathWithoutReplacement> = Vec::new(),
532 #[conf_deprecated("Please use `disallowed-names` instead", disallowed_names)]
536 blacklisted_names: Vec<String> = Vec::new(),
537 #[lints(cargo_common_metadata)]
539 cargo_ignore_publish: bool = false,
540 #[lints(incompatible_msrv)]
542 check_incompatible_msrv_in_tests: bool = false,
543 #[lints(inconsistent_struct_constructor)]
562 check_inconsistent_struct_field_initializers: bool = false,
563 #[lints(missing_errors_doc, missing_panics_doc, missing_safety_doc, unnecessary_safety_doc)]
565 check_private_items: bool = false,
566 #[lints(cognitive_complexity)]
568 cognitive_complexity_threshold: u64 = 25,
569 #[conf_deprecated("Please use `cognitive-complexity-threshold` instead", cognitive_complexity_threshold)]
573 cyclomatic_complexity_threshold: u64 = 25,
574 #[disallowed_paths_allow_replacements = true]
576 #[lints(disallowed_macros)]
577 disallowed_macros: Vec<DisallowedPath> = Vec::new(),
578 #[disallowed_paths_allow_replacements = true]
580 #[lints(disallowed_methods)]
581 disallowed_methods: Vec<DisallowedPath> = Vec::new(),
582 #[lints(disallowed_names)]
586 disallowed_names: Vec<String> = DEFAULT_DISALLOWED_NAMES.iter().map(ToString::to_string).collect(),
587 #[disallowed_paths_allow_replacements = true]
589 #[lints(disallowed_types)]
590 disallowed_types: Vec<DisallowedPath> = Vec::new(),
591 #[lints(doc_markdown)]
597 doc_valid_idents: Vec<String> = DEFAULT_DOC_VALID_IDENTS.iter().map(ToString::to_string).collect(),
598 #[lints(non_send_fields_in_send_ty)]
600 enable_raw_pointer_heuristic_for_send: bool = true,
601 #[lints(explicit_iter_loop)]
619 enforce_iter_loop_reborrow: bool = false,
620 #[lints(missing_enforced_import_renames)]
622 enforced_import_renames: Vec<Rename> = Vec::new(),
623 #[lints(enum_variant_names)]
625 enum_variant_name_threshold: u64 = 3,
626 #[lints(large_enum_variant)]
628 enum_variant_size_threshold: u64 = 200,
629 #[lints(excessive_nesting)]
631 excessive_nesting_threshold: u64 = 0,
632 #[lints(large_futures)]
634 future_size_threshold: u64 = 16 * 1024,
635 #[lints(borrow_interior_mutable_const, declare_interior_mutable_const, ifs_same_cond, mutable_key_type)]
637 ignore_interior_mutability: Vec<String> = Vec::from(["bytes::Bytes".into()]),
638 #[lints(result_large_err)]
640 large_error_threshold: u64 = 128,
641 #[lints(collapsible_if)]
644 lint_commented_code: bool = false,
645 #[conf_deprecated("Please use `check-inconsistent-struct-field-initializers` instead", check_inconsistent_struct_field_initializers)]
650 lint_inconsistent_struct_field_initializers: bool = false,
651 #[lints(decimal_literal_representation)]
653 literal_representation_threshold: u64 = 16384,
654 #[lints(manual_let_else)]
657 matches_for_let_else: MatchLintBehaviour = MatchLintBehaviour::WellKnownTypes,
658 #[lints(fn_params_excessive_bools)]
660 max_fn_params_bools: u64 = 3,
661 #[lints(large_include_file)]
663 max_include_file_size: u64 = 1_000_000,
664 #[lints(struct_excessive_bools)]
666 max_struct_bools: u64 = 3,
667 #[lints(index_refutable_slice)]
671 max_suggested_slice_pattern_length: u64 = 3,
672 #[lints(type_repetition_in_bounds)]
674 max_trait_bounds: u64 = 3,
675 #[lints(min_ident_chars)]
677 min_ident_chars_threshold: u64 = 1,
678 #[lints(missing_docs_in_private_items)]
681 missing_docs_in_crate_items: bool = false,
682 #[lints(arbitrary_source_item_ordering)]
684 module_item_order_groupings: SourceItemOrderingModuleItemGroupings = DEFAULT_MODULE_ITEM_ORDERING_GROUPS.into(),
685 #[lints(arbitrary_source_item_ordering)]
690 module_items_ordered_within_groupings: SourceItemOrderingWithinModuleItemGroupings =
691 SourceItemOrderingWithinModuleItemGroupings::None,
692 #[default_text = "current version"]
694 #[lints(
695 allow_attributes,
696 allow_attributes_without_reason,
697 almost_complete_range,
698 approx_constant,
699 assigning_clones,
700 borrow_as_ptr,
701 cast_abs_to_unsigned,
702 checked_conversions,
703 cloned_instead_of_copied,
704 collapsible_match,
705 collapsible_str_replace,
706 deprecated_cfg_attr,
707 derivable_impls,
708 err_expect,
709 filter_map_next,
710 from_over_into,
711 if_then_some_else_none,
712 index_refutable_slice,
713 io_other_error,
714 iter_kv_map,
715 legacy_numeric_constants,
716 lines_filter_map_ok,
717 manual_abs_diff,
718 manual_bits,
719 manual_c_str_literals,
720 manual_clamp,
721 manual_div_ceil,
722 manual_flatten,
723 manual_hash_one,
724 manual_is_ascii_check,
725 manual_is_power_of_two,
726 manual_let_else,
727 manual_midpoint,
728 manual_non_exhaustive,
729 manual_option_as_slice,
730 manual_pattern_char_comparison,
731 manual_range_contains,
732 manual_rem_euclid,
733 manual_repeat_n,
734 manual_retain,
735 manual_slice_fill,
736 manual_split_once,
737 manual_str_repeat,
738 manual_strip,
739 manual_try_fold,
740 map_clone,
741 map_unwrap_or,
742 map_with_unused_argument_over_ranges,
743 match_like_matches_macro,
744 mem_replace_option_with_some,
745 mem_replace_with_default,
746 missing_const_for_fn,
747 needless_borrow,
748 non_std_lazy_statics,
749 option_as_ref_deref,
750 option_map_unwrap_or,
751 ptr_as_ptr,
752 question_mark,
753 redundant_field_names,
754 redundant_static_lifetimes,
755 repeat_vec_with_capacity,
756 same_item_push,
757 seek_from_current,
758 seek_rewind,
759 transmute_ptr_to_ref,
760 tuple_array_conversions,
761 type_repetition_in_bounds,
762 unchecked_duration_subtraction,
763 uninlined_format_args,
764 unnecessary_lazy_evaluations,
765 unnested_or_patterns,
766 unused_trait_names,
767 use_self,
768 )]
769 msrv: Msrv = Msrv::default(),
770 #[lints(large_types_passed_by_value)]
772 pass_by_value_size_limit: u64 = 256,
773 #[lints(pub_underscore_fields)]
776 pub_underscore_fields_behavior: PubUnderscoreFieldsBehaviour = PubUnderscoreFieldsBehaviour::PubliclyExported,
777 #[lints(semicolon_inside_block)]
779 semicolon_inside_block_ignore_singleline: bool = false,
780 #[lints(semicolon_outside_block)]
782 semicolon_outside_block_ignore_multiline: bool = false,
783 #[lints(many_single_char_names)]
785 single_char_binding_names_threshold: u64 = 4,
786 #[lints(arbitrary_source_item_ordering)]
788 source_item_ordering: SourceItemOrdering = DEFAULT_SOURCE_ITEM_ORDERING.into(),
789 #[lints(large_stack_frames)]
791 stack_size_threshold: u64 = 512_000,
792 #[lints(nonstandard_macro_braces)]
798 standard_macro_braces: Vec<MacroMatcher> = Vec::new(),
799 #[lints(struct_field_names)]
801 struct_field_name_threshold: u64 = 3,
802 #[lints(indexing_slicing)]
808 suppress_restriction_lint_in_const: bool = false,
809 #[lints(boxed_local, useless_vec)]
811 too_large_for_stack: u64 = 200,
812 #[lints(too_many_arguments)]
814 too_many_arguments_threshold: u64 = 7,
815 #[lints(too_many_lines)]
817 too_many_lines_threshold: u64 = 100,
818 #[lints(arbitrary_source_item_ordering)]
820 trait_assoc_item_kinds_order: SourceItemOrderingTraitAssocItemKinds = DEFAULT_TRAIT_ASSOC_ITEM_KINDS_ORDER.into(),
821 #[default_text = "target_pointer_width * 2"]
824 #[lints(trivially_copy_pass_by_ref)]
825 trivial_copy_size_limit: Option<u64> = None,
826 #[lints(type_complexity)]
828 type_complexity_threshold: u64 = 250,
829 #[lints(unnecessary_box_returns)]
831 unnecessary_box_size: u64 = 128,
832 #[lints(unreadable_literal)]
834 unreadable_literal_lint_fractions: bool = true,
835 #[lints(upper_case_acronyms)]
837 upper_case_acronyms_aggressive: bool = false,
838 #[lints(vec_box)]
840 vec_box_size_threshold: u64 = 4096,
841 #[lints(verbose_bit_mask)]
843 verbose_bit_mask_threshold: u64 = 1,
844 #[lints(wildcard_imports)]
847 warn_on_all_wildcard_imports: bool = false,
848 #[lints(macro_metavars_in_unsafe)]
850 warn_unsafe_macro_metavars_in_private_macros: bool = false,
851}
852
853pub fn lookup_conf_file() -> io::Result<(Option<PathBuf>, Vec<String>)> {
859 const CONFIG_FILE_NAMES: [&str; 2] = [".clippy.toml", "clippy.toml"];
861
862 let mut current = env::var_os("CLIPPY_CONF_DIR")
865 .or_else(|| env::var_os("CARGO_MANIFEST_DIR"))
866 .map_or_else(|| PathBuf::from("."), PathBuf::from)
867 .canonicalize()?;
868
869 let mut found_config: Option<PathBuf> = None;
870 let mut warnings = vec![];
871
872 loop {
873 for config_file_name in &CONFIG_FILE_NAMES {
874 if let Ok(config_file) = current.join(config_file_name).canonicalize() {
875 match fs::metadata(&config_file) {
876 Err(e) if e.kind() == io::ErrorKind::NotFound => {},
877 Err(e) => return Err(e),
878 Ok(md) if md.is_dir() => {},
879 Ok(_) => {
880 if let Some(ref found_config) = found_config {
882 warnings.push(format!(
883 "using config file `{}`, `{}` will be ignored",
884 found_config.display(),
885 config_file.display()
886 ));
887 } else {
888 found_config = Some(config_file);
889 }
890 },
891 }
892 }
893 }
894
895 if found_config.is_some() {
896 return Ok((found_config, warnings));
897 }
898
899 if !current.pop() {
901 return Ok((None, warnings));
902 }
903 }
904}
905
906fn deserialize(file: &SourceFile) -> TryConf {
907 match toml::de::Deserializer::new(file.src.as_ref().unwrap()).deserialize_map(ConfVisitor(file)) {
908 Ok(mut conf) => {
909 extend_vec_if_indicator_present(&mut conf.conf.disallowed_names, DEFAULT_DISALLOWED_NAMES);
910 extend_vec_if_indicator_present(&mut conf.conf.allowed_prefixes, DEFAULT_ALLOWED_PREFIXES);
911 extend_vec_if_indicator_present(
912 &mut conf.conf.allow_renamed_params_for,
913 DEFAULT_ALLOWED_TRAITS_WITH_RENAMED_PARAMS,
914 );
915
916 if let SourceItemOrderingWithinModuleItemGroupings::Custom(groupings) =
919 &conf.conf.module_items_ordered_within_groupings
920 {
921 for grouping in groupings {
922 if !conf.conf.module_item_order_groupings.is_grouping(grouping) {
923 let names = conf.conf.module_item_order_groupings.grouping_names();
927 let suggestion = suggest_candidate(grouping, names.iter().map(String::as_str))
928 .map(|s| format!(" perhaps you meant `{s}`?"))
929 .unwrap_or_default();
930 let names = names.iter().map(|s| format!("`{s}`")).join(", ");
931 let message = format!(
932 "unknown ordering group: `{grouping}` was not specified in `module-items-ordered-within-groupings`,{suggestion} expected one of: {names}"
933 );
934
935 let span = conf
936 .value_spans
937 .get("module_item_order_groupings")
938 .cloned()
939 .unwrap_or_default();
940 conf.errors.push(ConfError::spanned(file, message, None, span));
941 }
942 }
943 }
944
945 if conf.conf.allowed_idents_below_min_chars.iter().any(|e| e == "..") {
947 conf.conf
948 .allowed_idents_below_min_chars
949 .extend(DEFAULT_ALLOWED_IDENTS_BELOW_MIN_CHARS.iter().map(ToString::to_string));
950 }
951 if conf.conf.doc_valid_idents.iter().any(|e| e == "..") {
952 conf.conf
953 .doc_valid_idents
954 .extend(DEFAULT_DOC_VALID_IDENTS.iter().map(ToString::to_string));
955 }
956
957 conf
958 },
959 Err(e) => TryConf::from_toml_error(file, &e),
960 }
961}
962
963fn extend_vec_if_indicator_present(vec: &mut Vec<String>, default: &[&str]) {
964 if vec.contains(&"..".to_string()) {
965 vec.extend(default.iter().map(ToString::to_string));
966 }
967}
968
969impl Conf {
970 pub fn read(sess: &Session, path: &io::Result<(Option<PathBuf>, Vec<String>)>) -> &'static Conf {
971 static CONF: OnceLock<Conf> = OnceLock::new();
972 CONF.get_or_init(|| Conf::read_inner(sess, path))
973 }
974
975 fn read_inner(sess: &Session, path: &io::Result<(Option<PathBuf>, Vec<String>)>) -> Conf {
976 match path {
977 Ok((_, warnings)) => {
978 for warning in warnings {
979 sess.dcx().warn(warning.clone());
980 }
981 },
982 Err(error) => {
983 sess.dcx()
984 .err(format!("error finding Clippy's configuration file: {error}"));
985 },
986 }
987
988 let TryConf {
989 mut conf,
990 value_spans: _,
991 errors,
992 warnings,
993 } = match path {
994 Ok((Some(path), _)) => match sess.source_map().load_file(path) {
995 Ok(file) => deserialize(&file),
996 Err(error) => {
997 sess.dcx().err(format!("failed to read `{}`: {error}", path.display()));
998 TryConf::default()
999 },
1000 },
1001 _ => TryConf::default(),
1002 };
1003
1004 conf.msrv.read_cargo(sess);
1005
1006 for error in errors {
1008 let mut diag = sess.dcx().struct_span_err(
1009 error.span,
1010 format!("error reading Clippy's configuration file: {}", error.message),
1011 );
1012
1013 if let Some(sugg) = error.suggestion {
1014 diag.span_suggestion(error.span, sugg.message, sugg.suggestion, Applicability::MaybeIncorrect);
1015 }
1016
1017 diag.emit();
1018 }
1019
1020 for warning in warnings {
1021 sess.dcx().span_warn(
1022 warning.span,
1023 format!("error reading Clippy's configuration file: {}", warning.message),
1024 );
1025 }
1026
1027 conf
1028 }
1029}
1030
1031const SEPARATOR_WIDTH: usize = 4;
1032
1033#[derive(Debug)]
1034struct FieldError {
1035 error: String,
1036 suggestion: Option<Suggestion>,
1037}
1038
1039#[derive(Debug)]
1040struct Suggestion {
1041 message: &'static str,
1042 suggestion: &'static str,
1043}
1044
1045impl std::error::Error for FieldError {}
1046
1047impl Display for FieldError {
1048 fn fmt(&self, f: &mut Formatter<'_>) -> fmt::Result {
1049 f.pad(&self.error)
1050 }
1051}
1052
1053impl serde::de::Error for FieldError {
1054 fn custom<T: Display>(msg: T) -> Self {
1055 Self {
1056 error: msg.to_string(),
1057 suggestion: None,
1058 }
1059 }
1060
1061 fn unknown_field(field: &str, expected: &'static [&'static str]) -> Self {
1062 use fmt::Write;
1065
1066 let metadata = get_configuration_metadata();
1067 let deprecated = metadata
1068 .iter()
1069 .filter_map(|conf| {
1070 if conf.deprecation_reason.is_some() {
1071 Some(conf.name.as_str())
1072 } else {
1073 None
1074 }
1075 })
1076 .collect::<Vec<_>>();
1077
1078 let mut expected = expected
1079 .iter()
1080 .copied()
1081 .filter(|name| !deprecated.contains(name))
1082 .collect::<Vec<_>>();
1083 expected.sort_unstable();
1084
1085 let (rows, column_widths) = calculate_dimensions(&expected);
1086
1087 let mut msg = format!("unknown field `{field}`, expected one of");
1088 for row in 0..rows {
1089 writeln!(msg).unwrap();
1090 for (column, column_width) in column_widths.iter().copied().enumerate() {
1091 let index = column * rows + row;
1092 let field = expected.get(index).copied().unwrap_or_default();
1093 write!(msg, "{:SEPARATOR_WIDTH$}{field:column_width$}", " ").unwrap();
1094 }
1095 }
1096
1097 let suggestion = suggest_candidate(field, expected).map(|suggestion| Suggestion {
1098 message: "perhaps you meant",
1099 suggestion,
1100 });
1101
1102 Self { error: msg, suggestion }
1103 }
1104}
1105
1106fn calculate_dimensions(fields: &[&str]) -> (usize, Vec<usize>) {
1107 let columns = env::var("CLIPPY_TERMINAL_WIDTH")
1108 .ok()
1109 .and_then(|s| <usize as FromStr>::from_str(&s).ok())
1110 .map_or(1, |terminal_width| {
1111 let max_field_width = fields.iter().map(|field| field.len()).max().unwrap();
1112 cmp::max(1, terminal_width / (SEPARATOR_WIDTH + max_field_width))
1113 });
1114
1115 let rows = fields.len().div_ceil(columns);
1116
1117 let column_widths = (0..columns)
1118 .map(|column| {
1119 if column < columns - 1 {
1120 (0..rows)
1121 .map(|row| {
1122 let index = column * rows + row;
1123 let field = fields.get(index).copied().unwrap_or_default();
1124 field.len()
1125 })
1126 .max()
1127 .unwrap()
1128 } else {
1129 0
1131 }
1132 })
1133 .collect::<Vec<_>>();
1134
1135 (rows, column_widths)
1136}
1137
1138fn suggest_candidate<'a, I>(value: &str, candidates: I) -> Option<&'a str>
1141where
1142 I: IntoIterator<Item = &'a str>,
1143{
1144 candidates
1145 .into_iter()
1146 .filter_map(|expected| {
1147 let dist = edit_distance(value, expected, 4)?;
1148 Some((dist, expected))
1149 })
1150 .min_by_key(|&(dist, _)| dist)
1151 .map(|(_, suggestion)| suggestion)
1152}
1153
1154#[cfg(test)]
1155mod tests {
1156 use serde::de::IgnoredAny;
1157 use std::collections::{HashMap, HashSet};
1158 use std::fs;
1159 use walkdir::WalkDir;
1160
1161 #[test]
1162 fn configs_are_tested() {
1163 let mut names: HashSet<String> = crate::get_configuration_metadata()
1164 .into_iter()
1165 .filter_map(|meta| {
1166 if meta.deprecation_reason.is_none() {
1167 Some(meta.name.replace('_', "-"))
1168 } else {
1169 None
1170 }
1171 })
1172 .collect();
1173
1174 let toml_files = WalkDir::new("../tests")
1175 .into_iter()
1176 .map(Result::unwrap)
1177 .filter(|entry| entry.file_name() == "clippy.toml");
1178
1179 for entry in toml_files {
1180 let file = fs::read_to_string(entry.path()).unwrap();
1181 #[allow(clippy::zero_sized_map_values)]
1182 if let Ok(map) = toml::from_str::<HashMap<String, IgnoredAny>>(&file) {
1183 for name in map.keys() {
1184 names.remove(name.as_str());
1185 }
1186 }
1187 }
1188
1189 assert!(
1190 names.is_empty(),
1191 "Configuration variable lacks test: {names:?}\nAdd a test to `tests/ui-toml`"
1192 );
1193 }
1194}