## Checkstyle Results The following document contains the results of Checkstyle 6.1.1 with /Users/rgoers/projects/apache/logging/log4j/log4j2/git/master/log4j-api/../checkstyle.xml ruleset. ## Summary
Files | Info | Warnings | Errors
--- | --- | --- | ---
70 | 9 | 0 | 98
## Files
File | I | W | E
--- | --- | --- | ---
org/apache/logging/log4j/EventLogger.java | 0 | 0 | 1
org/apache/logging/log4j/Level.java | 0 | 0 | 12
org/apache/logging/log4j/LevelLogger.java | 0 | 0 | 1
org/apache/logging/log4j/LogManager.java | 1 | 0 | 11
org/apache/logging/log4j/MarkerManager.java | 1 | 0 | 2
org/apache/logging/log4j/ThreadContext.java | 0 | 0 | 1
org/apache/logging/log4j/message/LocalizedMessage.java | 0 | 0 | 1
org/apache/logging/log4j/message/ObjectMessage.java | 0 | 0 | 1
org/apache/logging/log4j/message/ParameterizedMessageFactory.java | 0 | 0 | 1
org/apache/logging/log4j/message/StringFormatterMessageFactory.java | 0 | 0 | 1
org/apache/logging/log4j/message/StructuredDataId.java | 0 | 0 | 4
org/apache/logging/log4j/simple/SimpleLogger.java | 0 | 0 | 3
org/apache/logging/log4j/spi/AbstractLogger.java | 0 | 0 | 14
org/apache/logging/log4j/spi/DefaultThreadContextMap.java | 0 | 0 | 4
org/apache/logging/log4j/spi/DefaultThreadContextStack.java | 0 | 0 | 2
org/apache/logging/log4j/spi/ExtendedLoggerWrapper.java | 0 | 0 | 2
org/apache/logging/log4j/spi/Provider.java | 0 | 0 | 3
org/apache/logging/log4j/spi/StandardLevel.java | 0 | 0 | 2
org/apache/logging/log4j/status/StatusLogger.java | 0 | 0 | 4
org/apache/logging/log4j/util/Chars.java | 0 | 0 | 8
org/apache/logging/log4j/util/EnglishEnums.java | 0 | 0 | 1
org/apache/logging/log4j/util/LoaderUtil.java | 0 | 0 | 9
org/apache/logging/log4j/util/PropertiesUtil.java | 0 | 0 | 1
org/apache/logging/log4j/util/ProviderUtil.java | 0 | 0 | 4
org/apache/logging/log4j/util/ReflectionUtil.java | 7 | 0 | 4
org/apache/logging/log4j/util/StringBuilders.java | 0 | 0 | 1
## Details ### org/apache/logging/log4j/EventLogger.java
Severity | Category | Rule | Message | Line
--- | --- | --- | --- | ---
Error | coding | DeclarationOrder | Variable access definition in wrong order. | 32
### org/apache/logging/log4j/Level.java
Severity | Category | Rule | Message | Line
--- | --- | --- | --- | ---
Error | naming | ConstantName | Name 'levels' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$|^capabilities$|^log$'. | 47
Error | coding | DeclarationOrder | Variable access definition in wrong order. | 52
Error | coding | DeclarationOrder | Variable access definition in wrong order. | 57
Error | coding | DeclarationOrder | Variable access definition in wrong order. | 62
Error | coding | DeclarationOrder | Variable access definition in wrong order. | 67
Error | coding | DeclarationOrder | Variable access definition in wrong order. | 72
Error | coding | DeclarationOrder | Variable access definition in wrong order. | 77
Error | coding | DeclarationOrder | Variable access definition in wrong order. | 82
Error | coding | DeclarationOrder | Variable access definition in wrong order. | 87
Error | coding | DeclarationOrder | Variable access definition in wrong order. | 103
Error | javadoc | JavadocStyle | First sentence should end with a period. | 142
Error | coding | SuperClone | Method 'clone' should call 'super.clone'. | 168
### org/apache/logging/log4j/LevelLogger.java
Severity | Category | Rule | Message | Line
--- | --- | --- | --- | ---
Error | javadoc | JavadocMethod | Expected @param tag for 'level'. | 154
### org/apache/logging/log4j/LogManager.java
Severity | Category | Rule | Message | Line
--- | --- | --- | --- | ---
Error | coding | DeclarationOrder | Variable access definition in wrong order. | 54
Error | coding | DeclarationOrder | Variable access definition in wrong order. | 61
Error | sizes | LineLength | Line is longer than 120 characters (found 168). | 105
Error | sizes | LineLength | Line is longer than 120 characters (found 164). | 119
Info | misc | TodoComment | Comment matches to-do format 'TODO:'. | 159
Error | sizes | LineLength | Line is longer than 120 characters (found 121). | 319
Error | sizes | LineLength | Line is longer than 120 characters (found 121). | 351
Error | sizes | LineLength | Line is longer than 120 characters (found 121). | 416
Error | sizes | LineLength | Line is longer than 120 characters (found 121). | 436
Error | sizes | LineLength | Line is longer than 120 characters (found 121). | 465
Error | sizes | LineLength | Line is longer than 120 characters (found 121). | 478
Error | coding | DeclarationOrder | Constructor definition in wrong order. | 532
### org/apache/logging/log4j/MarkerManager.java
Severity | Category | Rule | Message | Line
--- | --- | --- | --- | ---
Info | misc | TodoComment | Comment matches to-do format 'TODO:'. | 130
Error | sizes | LineLength | Line is longer than 120 characters (found 126). | 301
Error | whitespace | WhitespaceAfter | 'cast' is not followed by whitespace. | 301
### org/apache/logging/log4j/ThreadContext.java
Severity | Category | Rule | Message | Line
--- | --- | --- | --- | ---
Error | coding | DeclarationOrder | Constructor definition in wrong order. | 250
### org/apache/logging/log4j/message/LocalizedMessage.java
Severity | Category | Rule | Message | Line
--- | --- | --- | --- | ---
Error | sizes | LineLength | Line is longer than 120 characters (found 128). | 219
### org/apache/logging/log4j/message/ObjectMessage.java
Severity | Category | Rule | Message | Line
--- | --- | --- | --- | ---
Error | whitespace | NoWhitespaceAfter | '{' is followed by whitespace. | 70
### org/apache/logging/log4j/message/ParameterizedMessageFactory.java
Severity | Category | Rule | Message | Line
--- | --- | --- | --- | ---
Error | coding | DeclarationOrder | Variable access definition in wrong order. | 35
### org/apache/logging/log4j/message/StringFormatterMessageFactory.java
Severity | Category | Rule | Message | Line
--- | --- | --- | --- | ---
Error | coding | DeclarationOrder | Variable access definition in wrong order. | 35
### org/apache/logging/log4j/message/StructuredDataId.java
Severity | Category | Rule | Message | Line
--- | --- | --- | --- | ---
Error | coding | DeclarationOrder | Variable access definition in wrong order. | 33
Error | coding | DeclarationOrder | Variable access definition in wrong order. | 39
Error | coding | DeclarationOrder | Variable access definition in wrong order. | 45
Error | coding | DeclarationOrder | Variable access definition in wrong order. | 51
### org/apache/logging/log4j/simple/SimpleLogger.java
Severity | Category | Rule | Message | Line
--- | --- | --- | --- | ---
Error | whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 43
Error | regexp | RegexpSingleline | Line has trailing spaces. | 126
Error | sizes | LineLength | Line is longer than 120 characters (found 121). | 157
### org/apache/logging/log4j/spi/AbstractLogger.java
Severity | Category | Rule | Message | Line
--- | --- | --- | --- | ---
Error | coding | DeclarationOrder | Variable access definition in wrong order. | 40
Error | coding | DeclarationOrder | Variable access definition in wrong order. | 45
Error | coding | DeclarationOrder | Variable access definition in wrong order. | 50
Error | coding | DeclarationOrder | Variable access definition in wrong order. | 55
Error | coding | DeclarationOrder | Variable access definition in wrong order. | 60
Error | coding | DeclarationOrder | Variable access definition in wrong order. | 65
Error | sizes | LineLength | Line is longer than 120 characters (found 122). | 70
Error | coding | DeclarationOrder | Variable access definition in wrong order. | 70
Error | sizes | LineLength | Line is longer than 120 characters (found 122). | 98
Error | coding | DeclarationOrder | Instance variable definition in wrong order. | 103
Error | coding | DeclarationOrder | Instance variable definition in wrong order. | 105
Error | coding | DeclarationOrder | Constructor definition in wrong order. | 110
Error | coding | DeclarationOrder | Constructor definition in wrong order. | 120
Error | coding | DeclarationOrder | Constructor definition in wrong order. | 131
### org/apache/logging/log4j/spi/DefaultThreadContextMap.java
Severity | Category | Rule | Message | Line
--- | --- | --- | --- | ---
Error | regexp | RegexpSingleline | Line has trailing spaces. | 32
Error | coding | MagicNumber | '1231' is a magic number. | 132
Error | coding | MagicNumber | '1237' is a magic number. | 132
Error | regexp | RegexpSingleline | Line has trailing spaces. | 155
### org/apache/logging/log4j/spi/DefaultThreadContextStack.java
Severity | Category | Rule | Message | Line
--- | --- | --- | --- | ---
Error | sizes | LineLength | Line is longer than 120 characters (found 136). | 29
Error | naming | ConstantName | Name 'stack' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$|^capabilities$|^log$'. | 36
### org/apache/logging/log4j/spi/ExtendedLoggerWrapper.java
Severity | Category | Rule | Message | Line
--- | --- | --- | --- | ---
Error | regexp | RegexpSingleline | Line has trailing spaces. | 117
Error | sizes | LineLength | Line is longer than 120 characters (found 129). | 126
### org/apache/logging/log4j/spi/Provider.java
Severity | Category | Rule | Message | Line
--- | --- | --- | --- | ---
Error | coding | DeclarationOrder | Variable access definition in wrong order. | 35
Error | coding | DeclarationOrder | Variable access definition in wrong order. | 39
Error | coding | DeclarationOrder | Variable access definition in wrong order. | 43
### org/apache/logging/log4j/spi/StandardLevel.java
Severity | Category | Rule | Message | Line
--- | --- | --- | --- | ---
Error | coding | DeclarationOrder | Static variable definition in wrong order. | 70
Error | naming | ConstantName | Name 'levelSet' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$|^capabilities$|^log$'. | 70
### org/apache/logging/log4j/status/StatusLogger.java
Severity | Category | Rule | Message | Line
--- | --- | --- | --- | ---
Error | coding | DeclarationOrder | Variable access definition in wrong order. | 51
Error | sizes | LineLength | Line is longer than 120 characters (found 122). | 78
Error | blocks | EmptyBlock | Empty catch block. | 162
Error | sizes | LineLength | Line is longer than 120 characters (found 125). | 205
### org/apache/logging/log4j/util/Chars.java
Severity | Category | Rule | Message | Line
--- | --- | --- | --- | ---
Error | design | HideUtilityClassConstructor | Utility classes should not have a public or default constructor. | 22
Error | javadoc | JavadocVariable | Missing a Javadoc comment. | 24
Error | javadoc | JavadocVariable | Missing a Javadoc comment. | 25
Error | javadoc | JavadocVariable | Missing a Javadoc comment. | 26
Error | javadoc | JavadocVariable | Missing a Javadoc comment. | 27
Error | javadoc | JavadocVariable | Missing a Javadoc comment. | 28
Error | javadoc | JavadocVariable | Missing a Javadoc comment. | 29
Error | javadoc | JavadocVariable | Missing a Javadoc comment. | 30
### org/apache/logging/log4j/util/EnglishEnums.java
Severity | Category | Rule | Message | Line
--- | --- | --- | --- | ---
Error | sizes | LineLength | Line is longer than 120 characters (found 138). | 28
### org/apache/logging/log4j/util/LoaderUtil.java
Severity | Category | Rule | Message | Line
--- | --- | --- | --- | ---
Error | whitespace | WhitespaceAround | '{' is not followed by whitespace. | 36
Error | whitespace | WhitespaceAround | '}' is not preceded with whitespace. | 36
Error | coding | DeclarationOrder | Static variable definition in wrong order. | 43
Error | coding | DeclarationOrder | Static variable definition in wrong order. | 45
Error | coding | DeclarationOrder | Static variable definition in wrong order. | 49
Error | coding | DeclarationOrder | Static variable definition in wrong order. | 51
Error | coding | DeclarationOrder | Static variable definition in wrong order. | 53
Error | javadoc | JavadocType | Missing a Javadoc comment. | 89
Error | coding | MagicNumber | '31' is a magic number. | 257
### org/apache/logging/log4j/util/PropertiesUtil.java
Severity | Category | Rule | Message | Line
--- | --- | --- | --- | ---
Error | coding | DeclarationOrder | Constructor definition in wrong order. | 87
### org/apache/logging/log4j/util/ProviderUtil.java
Severity | Category | Rule | Message | Line
--- | --- | --- | --- | ---
Error | javadoc | JavadocVariable | Missing a Javadoc comment. | 52
Error | coding | DeclarationOrder | Variable access definition in wrong order. | 52
Error | coding | DeclarationOrder | Variable access definition in wrong order. | 59
Error | naming | StaticVariableName | Name 'INSTANCE' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 62
### org/apache/logging/log4j/util/ReflectionUtil.java
Severity | Category | Rule | Message | Line
--- | --- | --- | --- | ---
Error | coding | DeclarationOrder | Variable access definition in wrong order. | 56
Error | naming | ConstantName | Name 'JDK_7u25_OFFSET' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$|^capabilities$|^log$'. | 56
Info | misc | TodoComment | Comment matches to-do format 'TODO:'. | 111
Info | misc | TodoComment | Comment matches to-do format 'TODO:'. | 127
Info | misc | TodoComment | Comment matches to-do format 'TODO:'. | 131
Info | misc | TodoComment | Comment matches to-do format 'TODO:'. | 139
Info | misc | TodoComment | Comment matches to-do format 'TODO:'. | 210
Info | misc | TodoComment | Comment matches to-do format 'TODO:'. | 221
Error | javadoc | JavadocType | Missing a Javadoc comment. | 292
Info | misc | TodoComment | Comment matches to-do format 'TODO:'. | 310
Error | coding | DeclarationOrder | Constructor definition in wrong order. | 330
### org/apache/logging/log4j/util/StringBuilders.java
Severity | Category | Rule | Message | Line
--- | --- | --- | --- | ---
Error | design | HideUtilityClassConstructor | Utility classes should not have a public or default constructor. | 24